Repository navigation
Conversation
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
This reads well. Perhaps you could also add an acceptance test that exercises the new code paths? Or would that be too hard?
b144b92 to
c882d2a
Compare
|
Added in c882d2a. The acceptance test applies the S3 configuration twice, verifies the package and generated settings, and runs It is limited to the nightly repository because |
|
I can take a look tomorrow too. I'm using S3, and was doing some bits in my profile code around it, that I was planning to turn into some upstream module patch at some stage. |
alexjfisher
left a comment
alexjfisher
left a comment
There was a problem hiding this comment.
LGTM. I can't see anything I currently have fudged into my profile that couldn't be replaced when this goes into the module.
c882d2a to
b16430f
Compare
| @@ -0,0 +1,38 @@ | |||
| require 'spec_helper_acceptance' | |||
|
|
|||
| if fact('pulpcore_version') == 'nightly' | |||
There was a problem hiding this comment.
The tests don't fail so I think it isn't being executed now. The fact is probably not set.
There was a problem hiding this comment.
You're right: the S3 examples were skipped. Fixed in b39d3e3 by reading BEAKER_FACTER_pulpcore_version, which the CI matrix actually exports. The default local value is nightly as well.
I also corrected the installed-package assertion: pulpcore-storage-s3 is an RPM capability, so the test now uses rpm -q --whatprovides rather than treating it as a package name. Nightly acceptance still requires the package from theforeman/pulpcore-packaging#3189 to be published.
Ruby syntax passes; the full acceptance run is in CI.
b16430f to
a7ff9e6
Compare
Install the Pulpcore S3 package capability and configure Django storage while preserving filesystem defaults and local static assets. Select nightly acceptance coverage through the BEAKER_FACTER_pulpcore_version environment value supplied by the test matrix. AI-Assisted-By: GPT_5.6 Sol (project signature) AI-Tool: Codex (GPT-6)
a7ff9e6 to
b39d3e3
Compare
3 participants
Summary
Add optional S3-compatible content storage through
storage_backendandstorage_options. Filesystem content storage remains the default.Install the stable
pulpcore-storage-s3capability, pass storage options todjango-storages, preserve Django's local static-file backend, and omitMEDIA_ROOTand the unused media directory for S3.Dependency
The package capability is introduced by pulpcore-packaging#3189, following the merged django-storages packaging. Nightly acceptance jobs need that package published before they can pass.
Testing
pulpcore-manager check. It checks configuration and dependency loading, not an S3 upload/download round trip.BEAKER_FACTER_pulpcore_version, matching the CI matrix. It defaults to nightly for local runs.git diff --checkpass locally. Full unit and acceptance tests run in upstream CI; the local bundle is not installed.AI assistance: Codex (GPT-6). Project signature: GPT_5.6 Sol.